Detect tuple structs that are unconstructable due to re-export #133477

estebank · 2024-11-25T21:52:40Z

When a tuple-struct is re-exported that has inaccessible fields at the use scope, the type's constructor cannot be accessed through that re-export. We now account for this case and extend the resulting resolution error. We also check if the constructor would be accessible directly, not through the re-export, and if so, we suggest using the full path instead.

error[E0423]: cannot initialize a tuple struct which contains private fields
  --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:12:33
   |
LL |             let crate::Foo(x) = crate::Foo(42);
   |                                 ^^^^^^^^^^
   |
note: the type is accessed through this re-export, but the type's constructor is not visible in this import's scope due to private fields
  --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:3:9
   |
LL | pub use my_mod::Foo;
   |         ^^^^^^^^^^^
help: the type can be constructed directly, because its fields are available from the current scope
   |
LL |             let crate::Foo(x) = crate::my_mod::Foo(42);
   |                                 ~~~~~~~~~~~~~~~~~~

Fix #133343.

rustbot · 2024-11-25T21:52:50Z

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

wesleywiser · 2025-03-27T14:20:30Z

r? rust-lang/compiler

davidtwco · 2025-04-16T14:44:13Z

@bors r+ rollup

bors · 2025-04-16T14:44:16Z

📌 Commit 4063732 has been approved by davidtwco

It is now in the queue for this repository.

davidtwco · 2025-04-16T14:48:41Z

@bors r- needs a rebase

When a tuple-struct is re-exported that has inaccessible fields at the `use` scope, the type's constructor cannot be accessed through that re-export. We now account for this case and extend the resulting resolution error. We also check if the constructor would be accessible directly, not through the re-export, and if so, we suggest using the full path instead. ``` error[E0423]: cannot initialize a tuple struct which contains private fields --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:12:33 | LL | let crate::Foo(x) = crate::Foo(42); | ^^^^^^^^^^ | note: the type is accessed through this re-export, but the type's constructor is not visible in this import's scope due to private fields --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:3:9 | LL | pub use my_mod::Foo; | ^^^^^^^^^^^ help: the type can be constructed directly, because its fields are available from the current scope | LL | let crate::Foo(x) = crate::my_mod::Foo(42); | ~~~~~~~~~~~~~~~~~~ ``` Fix rust-lang#133343.

rustbot · 2025-09-28T21:33:45Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot · 2025-09-28T21:33:46Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- 8f7d61b

estebank · 2025-09-29T00:02:21Z

@bors r=davidtwco

bors · 2025-09-29T00:02:23Z

📌 Commit 8f7d61b has been approved by davidtwco

It is now in the queue for this repository.

Detect tuple structs that are unconstructable due to re-export When a tuple-struct is re-exported that has inaccessible fields at the `use` scope, the type's constructor cannot be accessed through that re-export. We now account for this case and extend the resulting resolution error. We also check if the constructor would be accessible directly, not through the re-export, and if so, we suggest using the full path instead. ``` error[E0423]: cannot initialize a tuple struct which contains private fields --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:12:33 | LL | let crate::Foo(x) = crate::Foo(42); | ^^^^^^^^^^ | note: the type is accessed through this re-export, but the type's constructor is not visible in this import's scope due to private fields --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:3:9 | LL | pub use my_mod::Foo; | ^^^^^^^^^^^ help: the type can be constructed directly, because its fields are available from the current scope | LL | let crate::Foo(x) = crate::my_mod::Foo(42); | ~~~~~~~~~~~~~~~~~~ ``` Fix rust-lang#133343.

Rollup of 6 pull requests Successful merges: - #133477 (Detect tuple structs that are unconstructable due to re-export) - #140916 (Fix unuseful span in type error in some format_args!() invocations) - #146979 (constify Default on Nanoseconds) - #147090 (Skip stack overflow handler for panic=immediate-abort) - #147092 (Do not compute optimized MIR if code does not type-check.) - #147127 (Add a leading dash to linker plugin arguments in the gcc codegen) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 7 pull requests Successful merges: - #133477 (Detect tuple structs that are unconstructable due to re-export) - #146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool) - #146979 (constify Default on Nanoseconds) - #147092 (Do not compute optimized MIR if code does not type-check.) - #147112 (all 48 keywords in just 300 characters) - #147122 (Fix some crash-test directives) - #147127 (Add a leading dash to linker plugin arguments in the gcc codegen) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #133477 - estebank:issue-133343, r=davidtwco Detect tuple structs that are unconstructable due to re-export When a tuple-struct is re-exported that has inaccessible fields at the `use` scope, the type's constructor cannot be accessed through that re-export. We now account for this case and extend the resulting resolution error. We also check if the constructor would be accessible directly, not through the re-export, and if so, we suggest using the full path instead. ``` error[E0423]: cannot initialize a tuple struct which contains private fields --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:12:33 | LL | let crate::Foo(x) = crate::Foo(42); | ^^^^^^^^^^ | note: the type is accessed through this re-export, but the type's constructor is not visible in this import's scope due to private fields --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:3:9 | LL | pub use my_mod::Foo; | ^^^^^^^^^^^ help: the type can be constructed directly, because its fields are available from the current scope | LL | let crate::Foo(x) = crate::my_mod::Foo(42); | ~~~~~~~~~~~~~~~~~~ ``` Fix #133343.

Zalathar · 2025-09-29T11:04:57Z

@rust-timer build d7fb5d1

rust-timer · 2025-09-29T12:16:51Z

Finished benchmarking commit (d7fb5d1): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.2%]	6
Regressions ❌ (secondary)	0.2%	[0.0%, 0.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.1%, 0.2%]	6

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -3.9%, secondary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.9%	[-3.9%, -3.9%]	1
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	-3.9%	[-3.9%, -3.9%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.945s -> 613.879s (30.63%)
Artifact size: 387.67 MiB -> 387.70 MiB (0.01%)

rustbot assigned cjgillot Nov 25, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2024

This comment was marked as resolved.

Sign in to view

rustbot assigned davidtwco and unassigned cjgillot Mar 27, 2025

davidtwco approved these changes Apr 16, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2025

estebank force-pushed the issue-133343 branch from 4063732 to 8f7d61b Compare September 28, 2025 21:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 29, 2025

Zalathar mentioned this pull request Sep 29, 2025

Rollup of 6 pull requests #147139

Closed

Zalathar mentioned this pull request Sep 29, 2025

Rollup of 7 pull requests #147140

Merged

bors merged commit e7760fa into rust-lang:master Sep 29, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Sep 29, 2025

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Sep 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Detect tuple structs that are unconstructable due to re-export #133477

Detect tuple structs that are unconstructable due to re-export #133477

Uh oh!

estebank commented Nov 25, 2024

Uh oh!

rustbot commented Nov 25, 2024

Uh oh!

This comment was marked as resolved.

wesleywiser commented Mar 27, 2025

Uh oh!

davidtwco commented Apr 16, 2025

Uh oh!

bors commented Apr 16, 2025

Uh oh!

davidtwco commented Apr 16, 2025

Uh oh!

rustbot commented Sep 28, 2025

Uh oh!

rustbot commented Sep 28, 2025

Uh oh!

estebank commented Sep 29, 2025

Uh oh!

bors commented Sep 29, 2025

Uh oh!

Uh oh!

Zalathar commented Sep 29, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Sep 29, 2025

Uh oh!

Uh oh!

Detect tuple structs that are unconstructable due to re-export #133477

Detect tuple structs that are unconstructable due to re-export #133477

Uh oh!

Conversation

estebank commented Nov 25, 2024

Uh oh!

rustbot commented Nov 25, 2024

Uh oh!

This comment was marked as resolved.

wesleywiser commented Mar 27, 2025

Uh oh!

davidtwco commented Apr 16, 2025

Uh oh!

bors commented Apr 16, 2025

Uh oh!

davidtwco commented Apr 16, 2025

Uh oh!

rustbot commented Sep 28, 2025

Uh oh!

rustbot commented Sep 28, 2025

Uh oh!

estebank commented Sep 29, 2025

Uh oh!

bors commented Sep 29, 2025

Uh oh!

Uh oh!

Zalathar commented Sep 29, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Sep 29, 2025

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!